You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The install.sh script for the node feature uses npm to install pnpm (Line 231: npm install -g pnpm).
Because npm does not pickup the proxy environmentals http_proxy, https_proxy and no_proxy (which are automatically propagated by docker when present in the ~/.docker/config.json configuration as httpProxy, httpsProxy and noProxy) by itself, the script will always fail behind a proxy.
This is a bug in the install script because this is a special situation not automatically handled by Visual Studio Code or Docker but which must be taken care of by the calling script.
Could you please fix this as follows (bash-compatible)?
[ !-z"$http_proxy" ] && npm set proxy="$http_proxy"
[ !-z"$https_proxy" ] && npm set https-proxy="$https_proxy"
[ !-z"$no_proxy" ] && npm set noproxy="$no_proxy"
npm install -g pnpm
The text was updated successfully, but these errors were encountered:
The request makes sense to me. Wondering, @jmedelmann would you be interested in contributing a PR with this change? We'd really appreciate it, thanks!
We could use #451 as reference, which adds a new "httpProxy" Feature option for the Terraform Feature. It uses the proxy which is either set by the Feature option or if one exists in the env variables.
The install.sh script for the node feature uses npm to install pnpm (Line 231:
npm install -g pnpm
).Because npm does not pickup the proxy environmentals
http_proxy
,https_proxy
andno_proxy
(which are automatically propagated by docker when present in the~/.docker/config.json
configuration ashttpProxy
,httpsProxy
andnoProxy
) by itself, the script will always fail behind a proxy.This is a bug in the install script because this is a special situation not automatically handled by Visual Studio Code or Docker but which must be taken care of by the calling script.
Could you please fix this as follows (bash-compatible)?
The text was updated successfully, but these errors were encountered: