Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe input eaten on capitalization/mode switch #371

Open
GabrielDTB opened this issue Aug 31, 2023 · 8 comments
Open

Swipe input eaten on capitalization/mode switch #371

GabrielDTB opened this issue Aug 31, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@GabrielDTB
Copy link

Thumb-Key Version
1.12.0

Describe the bug
If you hit capitalize, number pad mode, or switch layouts during a swipe input, after pressing but before releasing, the input is not sent and the key is left activated. Using the key again resets the key highlighting. This does not occur when tapping, only swiping.

This often happens to me when using two fingers to type.

To Reproduce
Steps to reproduce the behavior:

  1. Start swiping a letter
  2. Swipe capitalize
  3. Release the letter
  4. The key should stay lit up with no input sent

This can also be achieved through tapping number pad mode and through switching layouts by swiping left on #

@GabrielDTB GabrielDTB added the bug Something isn't working label Aug 31, 2023
@dessalines
Copy link
Owner

The key should stay lit up with no input sent

Why should that be intended behavior? Seems very strange to me.

I don't know that I want to try to support holding actions and state in between pressing and releasing, that seems overly complicated for something as simple as: just wait until you've released a letter before you capitalize.

@dessalines dessalines closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2023
@GabrielDTB
Copy link
Author

I misread in my reply, and it would appear that you misread my original post. This is a bug report, not a feature request. The thing you asked why it would be intended behavior I agree with: It shouldn't be intended behavior. This is the behavior I observed as it is now.

@GabrielDTB
Copy link
Author

And to clarify, this is behavior that I observe in normal use just typing relatively quickly when I need to capitalize a letter mid-sentence. My finger don't always lift up off of the key before I hit the next key with the other finger -- it just happens.

@dessalines
Copy link
Owner

I still don't really understand.

The key should stay lit up with no input sent

You think the key should stay in a "lit up" state, for caps lock?

@GabrielDTB
Copy link
Author

That is the how to reproduce section. That is the behavior that you should observe when you perform the listed action. I don't understand what the confusion is.

@nejni-marji
Copy link
Contributor

The key does in fact stay lit up when you interrupt a key swipe with shift, which is probably undesired.

@nejni-marji
Copy link
Contributor

screen-20230831-180728.mp4

@dessalines
Copy link
Owner

Ah okay I see it now, thx.

@dessalines dessalines reopened this Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants