Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot PR description lists updates for packages that aren't allowed #10639

Open
1 task done
tippmar-nr opened this issue Sep 19, 2024 · 0 comments
Open
1 task done
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet T: bug 🐞 Something isn't working

Comments

@tippmar-nr
Copy link

tippmar-nr commented Sep 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

nuget

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

No response

dependabot.yml content

https://github.com/newrelic/newrelic-dotnet-agent/blob/main/.github/dependabot.yml#L28 -- refer to the the nuget-tests group starting at line 28

Updated dependency

No response

What you expected to see, versus what you actually saw

Observed behavor

We have an allow list that permits a small subset of Nuget packages to be updated.

On multiple occasions recently, the description in the PR created by Dependabot lists one or more "disallowed" packages as being included in the update, even though there are no changes to the actual manifest (.csproj) files for the disallowed packages.
Specific packages shown in the description include System.Net.Http, System.Collections.Immutable,

The PR itself updated exactly what it should have, based on the allow list; the issue is in the PR description itself.

Expected behavior

Disallowed packages should not appear in the description of Dependabot PRs

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

Recent Dependabot PRs exhibiting this behavior:

newrelic/newrelic-dotnet-agent#2746
newrelic/newrelic-dotnet-agent#2780
Both of these list System.Net.Http and Sytem.Collections.Immutable in the description, but there (correctly) not updated in the PR.

newrelic/newrelic-dotnet-agent#2702 -- this one listed a whole bunch of packages in the description, but the only package actually updated was Microsoft.NET.Test.Sdk, which is on the allow list.

Smallest manifest that reproduces the issue

No response

@tippmar-nr tippmar-nr added the T: bug 🐞 Something isn't working label Sep 19, 2024
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet T: bug 🐞 Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant