Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn v8_enable_shared_ro_heap on #1265

Open
ry opened this issue Jul 3, 2023 · 1 comment
Open

Turn v8_enable_shared_ro_heap on #1265

ry opened this issue Jul 3, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ry
Copy link
Member

ry commented Jul 3, 2023

We want to be inline with what default chrome configurations are using to reduce technical debt

rusty_v8/.gn

Lines 48 to 52 in ca83ce5

# Enabling the shared read-only heap comes with a restriction that all
# isolates running at the same time must be created from the same snapshot.
# This is problematic for Deno, which has separate "runtime" and "typescript
# compiler" snapshots, and sometimes uses them both at the same time.
v8_enable_shared_ro_heap = false

Problem: there are two snapshots in deno, the main runtime one, and the tsc one. How can we turn this on and also handle both of those? maybe don't snapshot tsc?

@mmastrac
Copy link
Contributor

mmastrac commented Jul 4, 2023

We might be able to fork before starting the snapshots which might allow us to use two snapshots side-by-side (just not in the same process). The benefit here would likely be a drastic memory reduction for the workers.

@devsnek devsnek added the enhancement New feature or request label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants