Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid >=16.8.0 && <=^19.0.0 constraint in package.json dependency values #41

Open
dsherret opened this issue Dec 13, 2024 · 2 comments

Comments

@dsherret
Copy link
Member

dsherret commented Dec 13, 2024

denoland/deno#26653 (comment)

npm considers this as just being >=16.8.0, but maybe we should be smarter about this?

@korkje
Copy link

korkje commented Dec 18, 2024

This is somewhat related, though the concern is specifiers that don't have support here in the first place:
denoland/deno#26587

@dsherret
Copy link
Member Author

dsherret commented Dec 18, 2024

That's different because it's related to specifiers. This is for in a package.json dependency entry. For specifiers we would never allow invalid ranges like this and instead surface an error so the user knows it's invalid.

@dsherret dsherret changed the title Handle invalid >=16.8.0 && <=^19.0.0 constraint Handle invalid >=16.8.0 && <=^19.0.0 constraint in package.json dependency values Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants