Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno outdated flag clash #27387

Open
bartlomieju opened this issue Dec 16, 2024 · 3 comments
Open

deno outdated flag clash #27387

bartlomieju opened this issue Dec 16, 2024 · 3 comments
Labels
outdated Related to `deno outdated` tool

Comments

@bartlomieju
Copy link
Member

          I've found another confusing behavior of `deno outdated`
: deno outdated                   
: deno outdated --compatible
┌─────────────┬────────────────┬────────────────┬─────────┐
│ Package     │ Current        │ Update         │ Latest  │
├─────────────┼────────────────┼────────────────┼─────────┤
│ npm:daisyui │ 5.0.0-alpha.47 │ 5.0.0-alpha.48 │ 4.12.22 │
└─────────────┴────────────────┴────────────────┴─────────┘

Run deno outdated --update to update to the latest compatible versions,
or deno outdated --help for more information.
: deno outdated --compatible -u
error: the argument '--compatible' cannot be used with '--update'

Usage: deno outdated --compatible [filters]...
: deno outdated  -u
Updated 1 dependency:
 - npm:daisyui 5.0.0-alpha.47 -> 5.0.0-alpha.48

I would expect deno outdated -u to do nothing if deno outdated outputs nothing and deno outdated --compatible -u to update daisyui to the update version outputed by deno outdated --compatible but -u doesn't work with --compatible

Originally posted by @kuchta in #27025 (comment)

@bartlomieju bartlomieju added triage required 👀 Deno team needs to make a decision if this change is desired outdated Related to `deno outdated` tool labels Dec 16, 2024
@nathanwhit
Copy link
Member

if i'm reading correctly this is #27038 and a request to allow --compatible with --update

@nathanwhit nathanwhit removed the triage required 👀 Deno team needs to make a decision if this change is desired label Dec 16, 2024
@kuchta
Copy link

kuchta commented Dec 16, 2024

@nathanwhit Basically yes. The main point is that it should be clear what --update would update, since --update doesn't ask for confirmation so the user wouldn't know what would be updated. It would also help if cli documentation would be more clear about how many modes or operation there actually are and which is the default, because right now there seems to be three modes of operation for displaying, but only two for updating and it also seems like the default one for update

Update dependencies to latest semver compatible versions:
  deno outdated --update

is not the default one for output deno outdated since deno outdated -u basically functions like deno outdated --compatible -u

So it would be best if all modes for output would have consistent update counterpart

@kuchta
Copy link

kuchta commented Dec 18, 2024

@nathanwhit I just want to add, that I think that the deno outdate -u (deno outdated --compatible counterpart) is probably the right default (without any flag), since the default should probably be the most conservative one, so it would be reasonable if the second non-default mode expanded the selection instead of narrowing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outdated Related to `deno outdated` tool
Projects
None yet
Development

No branches or pull requests

3 participants