Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing dependencies deduplication with jsr when using both package.json and deno.json causes resolution issues #27380

Open
lowlighter opened this issue Dec 16, 2024 · 0 comments

Comments

@lowlighter
Copy link
Contributor

Version: deno 2.1.4

If you have the same dependency specified in both deno.json/package.json, then it shouldn't be added to the packageJson of the deno lockfile.

This causes resolution issues in some case (e.g. deployctl): Error: The deployment failed: npm package '@jsr/std__assert' does not exist..

// deno.jsonc
{ 
  "imports": {
      "@std/assert": "jsr:@std/assert@^1.0.9"
  }
}
// package.json
{
  "dependencies": {
    "@std/assert": "npm:@jsr/std__assert@^1.0.9"
  }
}
// deno.lock
{
  "specifiers": {
    "jsr:@std/assert@1": "1.0.9",
    "jsr:@std/assert@^1.0.9": "1.0.9",
  },
  "packageJson": {
    "dependencies": [
      "npm:@jsr/std__assert@^1.0.9",
    ]
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant