Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Graph isn't displayed #9

Open
Anonymyous678 opened this issue Jun 15, 2023 · 9 comments
Open

Bug: Graph isn't displayed #9

Anonymyous678 opened this issue Jun 15, 2023 · 9 comments

Comments

@Anonymyous678
Copy link

Screenshot_2023-06-15-21-24-53-925-edit_org endmyopia calc
Screenshot_2023-06-15-21-24-28-876-edit_org endmyopia calc
Screenshot_2023-06-15-21-24-22-388-edit_org endmyopia calc
Why the diopter history graph isn't displayed for me? I have saved enough measurements in history to generate it. I have the latest version of app downloaded from app store.

@Anonymyous678
Copy link
Author

@denisk20 please take a look at it, do you need more info to debug it? I tried to export measurements, reinstall app, take 2 fresh measurements and graph was displayed, but once I imported my measurement data, it stopped displaying the graph. Should I send you the json file with measurements? Maybe it's some bug how it's saved there.

@denisk20
Copy link
Owner

I haven't seen anything like this. If you post your json I can take a look.

@Anonymyous678
Copy link
Author

@Anonymyous678
Copy link
Author

@denisk20 So, did you check it?

@denisk20
Copy link
Owner

Thanks for submitting it. I was able to reproduce the issue. I'll try to fix it in the upcoming days and update the app. Will let you know when it's ready.

@denisk20
Copy link
Owner

It seems there's a problem with the chart library that I use, it simply can't handle such amounts of measurements. I need to update the logic to interpolate the values for the chart. This is not a quick fix, I'll post here when it's done.

@Anonymyous678
Copy link
Author

Anonymyous678 commented Jun 22, 2023 via email

@denisk20
Copy link
Owner

denisk20 commented Jun 30, 2023

I have made progress here, I have re-written all of the chart code to not use the problematic library. The chart might not look as pretty as before and is not zoomable, also one can't delete items directly from the chart anymore, but it should be fast and reliable (will test with large datasets). It should be ready in couple days.

@denisk20
Copy link
Owner

It's ready, the build is in Open Testing channel, I'll test on couple more phones and will release to the public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants