Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer 2 Peer Code Review #9

Open
HFG43 opened this issue Jun 16, 2023 · 0 comments
Open

Peer 2 Peer Code Review #9

HFG43 opened this issue Jun 16, 2023 · 0 comments

Comments

@HFG43
Copy link

HFG43 commented Jun 16, 2023

Great job on the way Jest testing functions were created. Very clear, clean, and straightforward. πŸ‘ŒπŸ‘πŸ‘πŸ±β€πŸ‘€
Also, we will like to highlight the use of manual mocks, and the way the window load was mocked.

A suggestion is to use a loop for the creation of the Task Mocks, to avoid the creation each of them.
Also, make sure that your Local Storage is clear before running the Tests.
A good advice will be also to avoid window 'commands' to ensure good practices on JavaScript.

Happy coding!
@grauJavier
@lRebornsl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant