Skip to content

Commit d73a9af

Browse files
maxitgrtyler
authored andcommitted
remove max_statistics_size from ColumnProperties
Signed-off-by: Max Piskunov <[email protected]>
1 parent 8667622 commit d73a9af

File tree

3 files changed

+1
-10
lines changed

3 files changed

+1
-10
lines changed

python/deltalake/table.py

+1-4
Original file line numberDiff line numberDiff line change
@@ -218,26 +218,23 @@ def __init__(
218218
self,
219219
dictionary_enabled: Optional[bool] = None,
220220
statistics_enabled: Optional[Literal["NONE", "CHUNK", "PAGE"]] = None,
221-
max_statistics_size: Optional[int] = None,
222221
bloom_filter_properties: Optional[BloomFilterProperties] = None,
223222
):
224223
"""Create a Column Properties instance for the Rust parquet writer:
225224
226225
Args:
227226
dictionary_enabled: Enable dictionary encoding for the column.
228227
statistics_enabled: Statistics level for the column.
229-
max_statistics_size: Maximum size of statistics for the column.
230228
bloom_filter_properties: Bloom Filter Properties for the column.
231229
"""
232230
self.dictionary_enabled = dictionary_enabled
233231
self.statistics_enabled = statistics_enabled
234-
self.max_statistics_size = max_statistics_size
235232
self.bloom_filter_properties = bloom_filter_properties
236233

237234
def __str__(self) -> str:
238235
return (
239236
f"dictionary_enabled: {self.dictionary_enabled}, statistics_enabled: {self.statistics_enabled}, "
240-
f"max_statistics_size: {self.max_statistics_size}, bloom_filter_properties: {self.bloom_filter_properties}"
237+
f"bloom_filter_properties: {self.bloom_filter_properties}"
241238
)
242239

243240

python/src/lib.rs

-4
Original file line numberDiff line numberDiff line change
@@ -1573,9 +1573,6 @@ fn set_writer_properties(writer_properties: PyWriterProperties) -> DeltaResult<W
15731573

15741574
properties = properties.set_statistics_enabled(enabled_statistics);
15751575
}
1576-
if let Some(max_statistics_size) = default_column_properties.max_statistics_size {
1577-
properties = properties.set_max_statistics_size(max_statistics_size);
1578-
}
15791576
if let Some(bloom_filter_properties) = default_column_properties.bloom_filter_properties {
15801577
if let Some(set_bloom_filter_enabled) = bloom_filter_properties.set_bloom_filter_enabled
15811578
{
@@ -1937,7 +1934,6 @@ pub struct BloomFilterProperties {
19371934
pub struct ColumnProperties {
19381935
pub dictionary_enabled: Option<bool>,
19391936
pub statistics_enabled: Option<String>,
1940-
pub max_statistics_size: Option<usize>,
19411937
pub bloom_filter_properties: Option<BloomFilterProperties>,
19421938
}
19431939

python/tests/test_writerproperties.py

-2
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,13 @@ def test_writer_properties_all_filled():
2929
"a": ColumnProperties(
3030
dictionary_enabled=True,
3131
statistics_enabled="CHUNK",
32-
max_statistics_size=40,
3332
bloom_filter_properties=BloomFilterProperties(
3433
set_bloom_filter_enabled=True, fpp=0.2, ndv=30
3534
),
3635
),
3736
"b": ColumnProperties(
3837
dictionary_enabled=True,
3938
statistics_enabled="PAGE",
40-
max_statistics_size=400,
4139
bloom_filter_properties=BloomFilterProperties(
4240
set_bloom_filter_enabled=False, fpp=0.2, ndv=30
4341
),

0 commit comments

Comments
 (0)