From b325e27574b531b2dd73bfb9aa447e5cf39aee82 Mon Sep 17 00:00:00 2001 From: "R. Tyler Croy" Date: Thu, 19 Sep 2024 13:53:27 +0000 Subject: [PATCH] fix: upgrade python ABI to 3.9 from 3.8 The release of pyo3 0.22.3 compells this since we cannot otherwise compile. The choice is between pinning 0.22.2 and upgrading our ABI, and I think it's better to upgrade the ABI --- crates/core/src/delta_datafusion/mod.rs | 4 +--- python/Cargo.toml | 2 +- python/src/lib.rs | 1 + 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/crates/core/src/delta_datafusion/mod.rs b/crates/core/src/delta_datafusion/mod.rs index dde8537078..bb1f98ecd5 100644 --- a/crates/core/src/delta_datafusion/mod.rs +++ b/crates/core/src/delta_datafusion/mod.rs @@ -77,9 +77,7 @@ use url::Url; use crate::delta_datafusion::expr::parse_predicate_expression; use crate::delta_datafusion::schema_adapter::DeltaSchemaAdapterFactory; use crate::errors::{DeltaResult, DeltaTableError}; -use crate::kernel::{ - Add, DataCheck, EagerSnapshot, Invariant, Snapshot, StructTypeExt, -}; +use crate::kernel::{Add, DataCheck, EagerSnapshot, Invariant, Snapshot, StructTypeExt}; use crate::logstore::LogStoreRef; use crate::table::builder::ensure_table_uri; use crate::table::state::DeltaTableState; diff --git a/python/Cargo.toml b/python/Cargo.toml index ad84112875..971047407b 100644 --- a/python/Cargo.toml +++ b/python/Cargo.toml @@ -44,7 +44,7 @@ deltalake-mount = { path = "../crates/mount" } [dependencies.pyo3] version = "0.22.2" -features = ["extension-module", "abi3", "abi3-py38"] +features = ["extension-module", "abi3", "abi3-py39"] [dependencies.deltalake] path = "../crates/deltalake" diff --git a/python/src/lib.rs b/python/src/lib.rs index 77db334283..b9951732b7 100644 --- a/python/src/lib.rs +++ b/python/src/lib.rs @@ -1418,6 +1418,7 @@ fn scalar_to_py<'py>(value: &Scalar, py_date: &Bound<'py, PyAny>) -> PyResult todo!("how should this be converted!"), }; Ok(val.into_bound(py))