fix: pin pyarrow and run clippy

Signed-off-by: Robert Pack <[email protected]>

Author: roeap

crates/azure/src/lib.rs

@@ -47,19 +47,19 @@ impl ObjectStoreFactory for AzureFactory {
         let config = config::AzureConfigHelper::try_new(options.as_azure_options())?.build()?;
 
         let (_, path) =
-            ObjectStoreScheme::parse(&url).map_err(|e| DeltaTableError::GenericError {
+            ObjectStoreScheme::parse(url).map_err(|e| DeltaTableError::GenericError {
                 source: Box::new(e),
             })?;
         let prefix = Path::parse(path)?;
 
         let mut builder = MicrosoftAzureBuilder::new().with_url(url.to_string());
 
         for (key, value) in config.iter() {
-            builder = builder.with_config(key.clone(), value.clone());
+            builder = builder.with_config(*key, value.clone());
         }
 
         let inner = builder
-            .with_retry(self.parse_retry_config(&options)?)
+            .with_retry(self.parse_retry_config(options)?)
             .build()?;
 
         let store = limit_store_handler(url_prefix_handler(inner, prefix.clone()), options);

crates/catalog-unity/src/lib.rs

@@ -75,11 +75,9 @@ pub enum UnityCatalogError {
 
 impl From<UnityCatalogError> for DataCatalogError {
     fn from(value: UnityCatalogError) -> Self {
-        match value {
-            _ => DataCatalogError::Generic {
-                catalog: "Unity",
-                source: Box::new(value),
-            },
+        DataCatalogError::Generic {
+            catalog: "Unity",
+            source: Box::new(value),
         }
     }
 }

crates/core/src/operations/add_column.rs

@@ -6,7 +6,7 @@ use delta_kernel::schema::StructType;
 use futures::future::BoxFuture;
 use itertools::Itertools;
 
-use super::transaction::{CommitBuilder, CommitProperties, PROTOCOL};
+use super::transaction::{CommitBuilder, CommitProperties};
 use super::{CustomExecuteHandler, Operation};
 use crate::kernel::{StructField, StructTypeExt};
 use crate::logstore::LogStoreRef;

crates/core/src/operations/merge/mod.rs

@@ -764,7 +764,7 @@ async fn execute(
             if df
                 .clone()
                 .schema()
-                .field_with_unqualified_name(&col_name.to_string())
+                .field_with_unqualified_name(col_name)
                 .is_err()
             // implies it doesn't exist
             {

crates/core/src/storage/mod.rs

@@ -356,21 +356,21 @@ pub trait RetryConfigParse {
         }
 
         if let Some(retry_timeout) = options.0.get("retry_timeout") {
-            retry_config.retry_timeout = parse_duration(&retry_timeout).map_err(|_| {
+            retry_config.retry_timeout = parse_duration(retry_timeout).map_err(|_| {
                 DeltaTableError::generic(format!("failed to parse \"{retry_timeout}\" as Duration"))
             })?;
         }
 
         if let Some(bc_init_backoff) = options.0.get("backoff_config.init_backoff") {
-            retry_config.backoff.init_backoff = parse_duration(&bc_init_backoff).map_err(|_| {
+            retry_config.backoff.init_backoff = parse_duration(bc_init_backoff).map_err(|_| {
                 DeltaTableError::generic(format!(
                     "failed to parse \"{bc_init_backoff}\" as Duration"
                 ))
             })?;
         }
 
         if let Some(bc_max_backoff) = options.0.get("backoff_config.max_backoff") {
-            retry_config.backoff.max_backoff = parse_duration(&bc_max_backoff).map_err(|_| {
+            retry_config.backoff.max_backoff = parse_duration(bc_max_backoff).map_err(|_| {
                 DeltaTableError::generic(format!(
                     "failed to parse \"{bc_max_backoff}\" as Duration"
                 ))
@@ -668,6 +668,6 @@ mod tests {
         assert_eq!(retry_config.retry_timeout, Duration::from_secs(300));
         assert_eq!(retry_config.backoff.init_backoff, Duration::from_secs(20));
         assert_eq!(retry_config.backoff.max_backoff, Duration::from_secs(3600));
-        assert_eq!(retry_config.backoff.base, 50 as f64);
+        assert_eq!(retry_config.backoff.base, 50_f64);
     }
 }

crates/gcp/src/lib.rs

@@ -48,19 +48,19 @@ impl ObjectStoreFactory for GcpFactory {
         let config = config::GcpConfigHelper::try_new(options.as_gcp_options())?.build()?;
 
         let (_, path) =
-            ObjectStoreScheme::parse(&url).map_err(|e| DeltaTableError::GenericError {
+            ObjectStoreScheme::parse(url).map_err(|e| DeltaTableError::GenericError {
                 source: Box::new(e),
             })?;
         let prefix = Path::parse(path)?;
 
         let mut builder = GoogleCloudStorageBuilder::new().with_url(url.to_string());
 
         for (key, value) in config.iter() {
-            builder = builder.with_config(key.clone(), value.clone());
+            builder = builder.with_config(*key, value.clone());
         }
 
         let inner = builder
-            .with_retry(self.parse_retry_config(&options)?)
+            .with_retry(self.parse_retry_config(options)?)
             .build()?;
 
         let gcs_backend = crate::storage::GcsStorageBackend::try_new(Arc::new(inner))?;

crates/lakefs/src/storage.rs

@@ -101,7 +101,7 @@ impl ObjectStoreFactory for LakeFSObjectStoreFactory {
         let mut builder = AmazonS3Builder::new().with_url(s3_url.to_string());
 
         for (key, value) in config.iter() {
-            builder = builder.with_config(key.clone(), value.clone());
+            builder = builder.with_config(*key, value.clone());
         }
 
         let inner = builder

python/pyproject.toml

@@ -16,7 +16,7 @@ classifiers = [
     "Programming Language :: Python :: 3.11",
     "Programming Language :: Python :: 3.12",
 ]
-dependencies = ["pyarrow>=16"]
+dependencies = ["pyarrow>=16,<19"]
 dynamic = ["version"]
 
 [project.optional-dependencies]

python/src/error.rs

@@ -101,9 +101,9 @@ pub enum PythonError {
     ThreadingError(String),
 }
 
-impl<T> Into<PythonError> for std::sync::PoisonError<T> {
-    fn into(self) -> PythonError {
-        PythonError::ThreadingError(self.to_string())
+impl<T> From<std::sync::PoisonError<T>> for PythonError {
+    fn from(val: std::sync::PoisonError<T>) -> Self {
+        PythonError::ThreadingError(val.to_string())
     }
 }
 

python/src/lib.rs

@@ -153,7 +153,7 @@ impl RawDeltaTable {
             ._table
             .lock()
             .map_err(|e| PyRuntimeError::new_err(e.to_string()))?;
-        (*original).state = state;
+        original.state = state;
         Ok(())
     }
 }