From 9d3000de814e2a83bd335acd6334210ab14075da Mon Sep 17 00:00:00 2001 From: Robin Schroer Date: Mon, 26 Aug 2024 13:47:56 +0900 Subject: [PATCH] Replace dots in review app subdomains While dots are valid, they don't work with our SSL certificate. I've already adapted the hats CI workflow to expect this change. --- app/models/review_app.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/review_app.rb b/app/models/review_app.rb index f3bfdca4..70cd0ce9 100644 --- a/app/models/review_app.rb +++ b/app/models/review_app.rb @@ -73,8 +73,8 @@ def computed_environment ] end - # replace underscores and downcase - not valid as subdomain + # replace dots & underscores and downcase - not valid as subdomain def sanitized_subject - subject.downcase.gsub('_', '-') + subject.downcase.gsub(/[._]/, '-') end end