Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify airgap friendly path for loading in grafana plugins #992

Closed
mjnagel opened this issue Nov 8, 2024 · 1 comment
Closed

Identify airgap friendly path for loading in grafana plugins #992

mjnagel opened this issue Nov 8, 2024 · 1 comment

Comments

@mjnagel
Copy link
Contributor

mjnagel commented Nov 8, 2024

Grafana provides methods to install plugins at startup, or load them at startup, either from remote sources (grafana.com) or from files on disk. We should identify a feasible path to load plugins that would be functional in the airgap, or at minimum provide recommendations for end users on how to achieve this.

Definition of done: a design doc for review on the approach to achieve this.

While not required for this ticket, there may be other applications with similar needs (i.e. Mattermost plugins) so a more generic solution would be nice.

mjnagel added a commit that referenced this issue Nov 8, 2024
## Description

The Grafana 11.3.0 update contained a [new default pre-install
plugin](https://grafana.com/docs/grafana/latest/whatsnew/whats-new-in-v11-3/#explore-logs).
While this plugin would be nice, the method of installation involves
reaching out to `grafana.com` on startup to download and install the
plugin. To workaround this for the time being this PR disables the
pre-install functionality.

In reviewing you should notice that before the change there are log
failures reaching out to grafana:
```
logger=plugin.backgroundinstaller t=2024-11-07T18:42:14.912141481Z level=info msg="Installing plugin" pluginId=grafana-lokiexplore-app version=
logger=plugin.backgroundinstaller t=2024-11-07T18:42:14.939302134Z level=error msg="Failed to install plugin" pluginId=grafana-lokiexplore-app version= error="Get \"https://grafana.com/api/plugins/grafana-lokiexplore-app/versions\": read tcp 10.42.0.36:49118->34.120.177.193:443: read: connection reset by peer"
```

After this change those failures do not exist.

## Related Issue

Related to #992

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
@mjnagel
Copy link
Contributor Author

mjnagel commented Mar 21, 2025

Closing as not planned for now, pending specific requests for this. For now end users should be able to load plugins by building a small docker image that contains any plugins they need, and adding this as an initContainer to grafana to copy the plugin to a shared volume.

@mjnagel mjnagel closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant