Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve token permissions issues detected by openssf scorecard #978

Closed
mjnagel opened this issue Nov 4, 2024 · 0 comments · Fixed by #1155
Closed

Resolve token permissions issues detected by openssf scorecard #978

mjnagel opened this issue Nov 4, 2024 · 0 comments · Fixed by #1155
Assignees
@UnicornChance

Comments

@mjnagel
Copy link
Contributor

mjnagel commented Nov 4, 2024

The OpenSSF scorecard workflow detected a number of issues with token permissions, primarily not setting token permissions at the right scopes. The full list is here: https://github.com/defenseunicorns/uds-core/security/code-scanning?query=token-permissions+is%3Aopen+branch%3Amain+severity%3Ahigh

Each of these should be resolved by updating the affected workflows and ensuring the security item closes out after a re-scan by the scorecard workflow.
@UnicornChance UnicornChance mentioned this issue Jan 6, 2025
Merged
5 tasks
@UnicornChance UnicornChance linked a pull request Jan 6, 2025 that will close this issue
fix: attempt fix token permissions #1155
Merged
5 tasks
UnicornChance added a commit that referenced this issue Jan 6, 2025
@UnicornChance
fix: attempt fix token permissions (#1155)
5a46e41 
## Description
Resolve Code Scanning Token Permissions issues

## Related Issue

Fixes #978 

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)


## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UnicornChance UnicornChance

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: attempt fix token permissions defenseunicorns/uds-core
2 participants
@mjnagel @UnicornChance