Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove helper functions dealing with maps #50

Open
Noxsios opened this issue Mar 28, 2024 · 0 comments
Open

remove helper functions dealing with maps #50

Noxsios opened this issue Mar 28, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Noxsios
Copy link
Contributor

Noxsios commented Mar 28, 2024

Describe what should be investigated or refactored

Now that https://pkg.go.dev/maps exists, there is no need for certain functions in helpers to exist. They should be deprecated and return the upstream maps versions of their operations.

Links to any relevant code

pkg/helpers/misc.go

Line 40 in fa0230e

func MergeMap[T any](m1, m2 map[string]T) (r map[string]T) {

@Noxsios Noxsios moved this to Backlog in Zarf (old) Mar 28, 2024
@lucasrod16 lucasrod16 mentioned this issue Mar 29, 2024
Merged
Noxsios pushed a commit that referenced this issue Mar 29, 2024
refactor!: delete MergeMap in favor of stdlib maps.Copy() (#55)
3b8a6cd 
## Description
delete `MergeMap`in favor of stdlib `maps.Copy()`

## Related Issue

Relates to #50
@Noxsios Noxsios added the good first issue Good for newcomers label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
No open projects
Zarf (old)
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Noxsios