Last url segment is removed from custom global url values

[lox]

What is the current behavior?

The last path segment gets trimmed from custom api endpoint urls.

If setting global: { url: 'https://example.com/test/url/is/long/' }, the url that is fetched for prerecorded transcribe is https://example.com/test/url/is/v1/listen (note the last segment removed).

This was unexpected!

For context, I am building a mock endpoint for our test suites.

Steps to reproduce

import { createClient } from '@deepgram/sdk'
import fs from 'fs'

const client = createClient('nope', {
  global: { url: 'https://example.com/test/url/is/long/' },
  _experimentalCustomFetch: (url, init) => {
    return Response.json({
      url: url.href,
    })
  },
})

const { result, error } = await client.listen.prerecorded.transcribeFile(
  fs.createReadStream('./testdata/polar-bear.webm'),
  {
    model: 'nova',
  }
)

console.log(result)
console.log(error)

Output is:

{
  url: 'https://example.com/test/url/is/v1/listen?model=nova'
}

Expected behavior

I would expect the last segment of the url to be preserved.

Please tell us about your environment

@deepgram/sdk 3.3.2

Other information

Looks like the trailing slash is trimmed in Interested in a PR that preserves the trailing slash here?

deepgram-js-sdk/src/packages/AbstractClient.ts

Line 81 in bd51da7

return new URL(stripTrailingSlash(url));

.

A hacky workaround is to add a double slash at the end.

[lukeocodes]

Interesting. I expect it is to do with how it is parsed using the URL class in JavaScript

[lukeocodes]

Hmm thinking more about this. We're trying to normalise the URL string for when we add it to the object. Is there a reason you need the trailing slash at all?