Skip to content

Commit ef97745

Browse files
authored
fix(kube-api-rewriter): respond with correct error (#611)
Signed-off-by: Daniil Antoshin <[email protected]>
1 parent 7b6711f commit ef97745

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

images/kube-api-rewriter/pkg/proxy/handler.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ import (
3333
"time"
3434

3535
"github.com/tidwall/gjson"
36+
k8serrors "k8s.io/apimachinery/pkg/api/errors"
3637

3738
"github.com/deckhouse/kube-api-rewriter/pkg/labels"
3839
logutil "github.com/deckhouse/kube-api-rewriter/pkg/log"
@@ -186,10 +187,8 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, req *http.Request) {
186187
resp, err := h.TargetClient.Do(req)
187188
if err != nil {
188189
logger.Error("Error passing request to the target", logutil.SlogErr(err))
189-
http.Error(w, "Error passing request to the target", http.StatusInternalServerError)
190+
http.Error(w, k8serrors.NewInternalError(err).Error(), http.StatusInternalServerError)
190191
metrics.TargetResponseError()
191-
// TODO return apimachinery NewInternalError
192-
// https://github.com/kubernetes/apimachinery/blob/master/pkg/api/errors/errors.go
193192
return
194193
}
195194

0 commit comments

Comments
 (0)