Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compressed file size check in Batch Writer #27

Open
thehenrytsai opened this issue Jun 23, 2020 · 1 comment
Open

Add compressed file size check in Batch Writer #27

thehenrytsai opened this issue Jun 23, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@thehenrytsai
Copy link
Contributor

thehenrytsai commented Jun 23, 2020 •
edited
Loading

The Batch Writer should ensure that the compressed CAS files it writes does not exceed protocol limits so that the operation batch is not rejected by the Observer.

Also consider similar size check for decompressed files, if this is done, we can potentially tighten the decompression multiplier (currently set to 3).
@thehenrytsai thehenrytsai added the enhancement New feature or request label Jun 23, 2020
@thehenrytsai thehenrytsai mentioned this issue Jun 23, 2020
Merged
@csuwildcat
Copy link
Member

I think this is done, right Henry?

@decentralgabe decentralgabe transferred this issue from decentralized-identity/sidetree Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csuwildcat @thehenrytsai