Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proposal] add support for Multikey #304

Closed
mirceanis opened this issue Jan 17, 2024 · 1 comment · Fixed by #305
Closed

[proposal] add support for Multikey #304

mirceanis opened this issue Jan 17, 2024 · 1 comment · Fixed by #305
Assignees
@mirceanis
Labels
enhancement New feature or request released

Comments

@mirceanis
Copy link
Member

Some DIDDocuments can use Multikey as a verification method type. The key type must then be inferred from the multibase(multicodec(keyBytes)) encoding found in the publicKeyMultibase property of the verification method.

Describe the solution you'd like
It should be possible to verify tokens whose issuer DID document contain Multikey verification methods at least pointing to the key types that are already supported.

Describe alternatives you've considered
Until #234 is fixed, the verification logic is hardcoded, so a fix must be provided here.

Additional context
https://www.w3.org/TR/vc-data-integrity/#multikey
https://identity.foundation/peer-did-method-spec/#resolving-a-didpeer2
https://w3c-ccg.github.io/did-method-key/#document-creation-algorithm
@mirceanis mirceanis added the enhancement New feature or request label Jan 17, 2024
@mirceanis mirceanis self-assigned this Jan 17, 2024
mirceanis added a commit that referenced this issue Jan 17, 2024
@mirceanis
feat: add support for Multikey
c12d361 
fixes #304

BREAKING CHANGE: The return types have changed for  of `extractPublicKeyBytes()` and `multibaseToBytes()` from Uint8Arrays to Objects containing the `keyBytes: Uint8Array` and a decoded or inferred `keyType: string | undefined`
@mirceanis mirceanis mentioned this issue Jan 17, 2024
Merged
mirceanis added a commit that referenced this issue Jan 18, 2024
@mirceanis
feat: add support for Multikey (#305)
20bbc3e 
fixes #304

BREAKING CHANGE: The return types have changed for  of `extractPublicKeyBytes()` and `multibaseToBytes()` from Uint8Arrays to Objects containing the `keyBytes: Uint8Array` and a decoded or inferred `keyType: string | undefined`
uport-automation-bot pushed a commit that referenced this issue Jan 18, 2024
@semantic-release-bot
chore(release): 8.0.0 [skip ci]
57461ab 
# [8.0.0](7.4.7...8.0.0) (2024-01-18)

### Features

* add support for Multikey ([#305](#305)) ([20bbc3e](20bbc3e)), closes [#304](#304)

### BREAKING CHANGES

* The return types have changed for  of `extractPublicKeyBytes()` and `multibaseToBytes()` from Uint8Arrays to Objects containing the `keyBytes: Uint8Array` and a decoded or inferred `keyType: string | undefined`
@uport-automation-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirceanis mirceanis

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for Multikey decentralized-identity/did-jwt
2 participants
@mirceanis @uport-automation-bot