Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underlying Token Address not being set #2614

Closed
Da-Colon opened this issue Dec 9, 2024 · 1 comment · Fixed by #2625
Closed

Underlying Token Address not being set #2614

Da-Colon opened this issue Dec 9, 2024 · 1 comment · Fixed by #2625
Assignees
@DarksightKellar
Labels
bug Something isn't working

Comments

@Da-Colon
Copy link
Contributor

Da-Colon commented Dec 9, 2024 •
edited
Loading

I'm reviewing the Data structure and noticed that in src/hooks/DAO/loaders/useGovernanceContracts.ts:

let underlyingTokenAddress: Address | undefined;

is not being used yet is being passed into the payload on line 125
@Da-Colon Da-Colon added this to Decent Dec 9, 2024
@Da-Colon Da-Colon converted this from a draft issue Dec 9, 2024
@Da-Colon Da-Colon moved this from In progress to Ready in Decent Dec 9, 2024
@Da-Colon Da-Colon moved this from Ready to In progress in Decent Dec 10, 2024
@Da-Colon Da-Colon added the bug Something isn't working label Dec 10, 2024
@Da-Colon Da-Colon moved this from In progress to Ready in Decent Dec 10, 2024
@DarksightKellar
Copy link
Contributor

This is probably leftover from the wrap functionality

@DarksightKellar DarksightKellar mentioned this issue Dec 11, 2024
Merged
@DarksightKellar DarksightKellar moved this from Ready to In review in Decent Dec 11, 2024
@DarksightKellar DarksightKellar self-assigned this Dec 11, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Decent Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarksightKellar DarksightKellar

Labels
bug Something isn't working
Projects
Decent
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove underlyingTokenAddress and loadUnderlyingERC20Token decentdao/decent-interface
2 participants
@DarksightKellar @Da-Colon