feat: Enhance platform-specific permission handling in 'take' command tests

- Updated 'take_test.go' to handle permission changes differently based on the operating system, specifically adding support for Windows using 'icacls'.
- Modified the temporary file creation in 'take.go' to ensure the correct file extension is used, defaulting to '.tar.gz' if none is provided.

These changes improve the cross-platform compatibility and robustness of the 'take' command, ensuring proper permission management and file handling across different environments.

Signed-off-by: Alessandro De Blasis <[email protected]>

Author: deblasis

pkg/take/take.go

@@ -172,8 +172,12 @@ func handleTarballURL(opts Options) Result {
 	}
 	defer os.RemoveAll(tmpDir)
 
-	// Create temporary file
-	tmpFile, err := os.CreateTemp(tmpDir, "archive-*.tar.*")
+	// Create temporary file with proper extension
+	ext := filepath.Ext(opts.Path)
+	if ext == "" {
+		ext = ".tar.gz" // default extension
+	}
+	tmpFile, err := os.CreateTemp(tmpDir, "archive-*"+ext)
 	if err != nil {
 		return Result{Error: err}
 	}

pkg/take/take_test.go

@@ -9,6 +9,7 @@ import (
 	"os/exec"
 	"archive/zip"
 	"io"
+	"runtime"
 )
 
 type testCase struct {
@@ -278,12 +279,24 @@ func TestTake(t *testing.T) {
 				if err := os.MkdirAll(path, 0755); err != nil {
 					t.Fatalf("Failed to create noperm directory: %v", err)
 				}
-				if err := os.Chmod(path, 0000); err != nil {
-					t.Fatalf("Failed to change permissions: %v", err)
+				if runtime.GOOS == "windows" {
+					cmd := exec.Command("icacls", path, "/deny", "Everyone:(OI)(CI)F")
+					if err := cmd.Run(); err != nil {
+						t.Fatalf("Failed to set permissions: %v", err)
+					}
+				} else {
+					if err := os.Chmod(path, 0000); err != nil {
+						t.Fatalf("Failed to change permissions: %v", err)
+					}
 				}
 			},
 			cleanup: func() error {
-				return os.Chmod(tmpPath("noperm"), 0755)
+				path := tmpPath("noperm")
+				if runtime.GOOS == "windows" {
+					cmd := exec.Command("icacls", path, "/reset")
+					return cmd.Run()
+				}
+				return os.Chmod(path, 0755)
 			},
 			opts: Options{
 				Path: tmpPath("noperm/child"),