hack: Fix shell errors in generating completions

Did not work on OS X due to missing function, was using the wrong
binary to execute.

Author: smarterclayton

hack/lib/init.sh

@@ -16,4 +16,7 @@ OS_ROOT="$(dirname "${BASH_SOURCE}")/../.."
 function os::build::host_platform() {
   echo "$(go env GOHOSTOS)/$(go env GOHOSTARCH)"
 }
+function os::log::warning() {
+  echo "warning: ${1}" 1>&2
+}
 readonly -f os::build::host_platform

hack/update-generated-completions.sh

@@ -14,7 +14,7 @@ function os::build::gen-completions() {
   local tmpdir="${OS_ROOT}/_tmp/gen_comp"
   mkdir -p "${tmpdir}"
   # generate the new files
-  ${OS_ROOT}/oc completion ${shell} > $tmpdir/oc
+  ${oc} completion ${shell} > $tmpdir/oc
   # create the list of generated files
   ls "${tmpdir}" | LC_ALL=C sort > "${tmpdir}/.files_generated"
 
@@ -42,9 +42,11 @@ function os::build::gen-completions() {
 }
 readonly -f os::build::gen-completions
 
+oc="${OS_ROOT}/oc"
 platform="$(os::build::host_platform)"
 if [[ "${platform}" != "linux/amd64" ]]; then
   os::log::warning "Generating completions on ${platform} may not be identical to running on linux/amd64 due to conditional compilation."
+  oc="${OS_ROOT}/_output/bin/${platform//\//_}/oc"
 fi
 
 OUTPUT_DIR_ROOT="${1:-${OS_ROOT}/contrib/completions}"

hack/verify-generated-completions.sh

@@ -14,11 +14,5 @@ COMPLETION_ROOT="${OS_ROOT}/${COMPLETION_ROOT_REL}"
 TMP_COMPLETION_ROOT_REL="_output/verify-generated-completions/"
 TMP_COMPLETION_ROOT="${OS_ROOT}/${TMP_COMPLETION_ROOT_REL}"
 
-platform="$(os::build::host_platform)"
-if [[ "${platform}" != "linux/amd64" ]]; then
-  os::log::warning "Completions cannot be verified on non-Linux systems (${platform})"
-  exit 0
-fi
-
 ${OS_ROOT}/hack/update-generated-completions.sh ${TMP_COMPLETION_ROOT_REL}
 diff -Naupr -x 'OWNERS' ${COMPLETION_ROOT} ${TMP_COMPLETION_ROOT}