Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor site.js #88

Closed
alulsh opened this issue Aug 17, 2016 · 2 comments
Closed

Refactor site.js #88

alulsh opened this issue Aug 17, 2016 · 2 comments
Labels
help wanted

Comments

@alulsh
Copy link
Member

alulsh commented Aug 17, 2016

#78 added awesome UI functionality but introduced 903 additional lines of code.

I think there's even more opportunities to refactor this file to slim down the main JavaScript codebase. Anybody want to tackle this?
@alulsh alulsh changed the title Refactor site.js Refactor site.js Aug 17, 2016
@alulsh alulsh mentioned this issue Aug 17, 2016
Merged
@hrecht
Copy link
Contributor

hrecht commented Aug 20, 2016

I'm working on #58 and site.js will need some major refactoring anyway to work with gl-js. Will work on slimming it down.

@hrecht hrecht mentioned this issue Aug 20, 2016
Merged
1 task
@alulsh
Copy link
Member Author

alulsh commented Sep 2, 2016

This was done in #58! Yay @hrecht! 👏 👏 👏

@alulsh alulsh closed this as completed Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hrecht @alulsh