Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dash with underscore for generated D files? #39

Open
AndrejMitrovic opened this issue Jun 2, 2023 · 0 comments
Open

Replace dash with underscore for generated D files? #39

AndrejMitrovic opened this issue Jun 2, 2023 · 0 comments

Comments

@AndrejMitrovic
Copy link

One of the upstream dependencies I'm targeting uses a file named kafka-egress.proto, this generates a D file named kafka-egress.d with a module declaration module kafka-egress.d.

This won't compile in D as - is not valid in a module declaration.

I could rename the upstream file, but I'd rather not taint the sources.

Could protobuf-d be fixed to replace - with an underscore _ in both the generated filename and the module declaration?
AndrejMitrovic added a commit to AndrejMitrovic/flink-statefun that referenced this issue Jun 2, 2023
@AndrejMitrovic
Rename files as they're not compatible with protobuf-d
c55fc54 
See dcarp/protobuf-d#39
AndrejMitrovic added a commit to AndrejMitrovic/flink-statefun that referenced this issue Jun 5, 2023
@AndrejMitrovic
Rename files as they're not compatible with protobuf-d
6895102 
See dcarp/protobuf-d#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndrejMitrovic