Skip to content

Commit c0e4785

Browse files
committed
Drop includeStorageKey during filter serialization, no longer needed
1 parent 97d3156 commit c0e4785

File tree

2 files changed

+7
-15
lines changed

2 files changed

+7
-15
lines changed

src/core/filter-storage.ts

+6-10
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { IFilterListenerParams, IFilterStorage, ISerializeOpts } from './i-filter-storage.js';
1+
import { IFilterListenerParams, IFilterStorage } from './i-filter-storage.js';
22
import { IFilter } from './filters/i-filter.js';
33
import { filterFactory } from './filters/filter-factory.js';
44
import { ISerializedFilters } from './i-serialized-filters.js';
@@ -100,7 +100,7 @@ export class FilterStorage implements IFilterStorage {
100100
this.setFiltersAndNotify(storageKey, filters);
101101
}
102102

103-
public serialize({ includeStorageKey }: ISerializeOpts = {}): ISerializedFilters[] {
103+
public serialize(): ISerializedFilters[] {
104104
// Include items that have active filters
105105
// In case of Composite charts, include only the parent chart
106106
return Array.from(this._listenerChains.values())
@@ -111,15 +111,11 @@ export class FilterStorage implements IFilterStorage {
111111
if (listener) {
112112
const filters = this._filters.get(listener.storageKey);
113113
if (filters && filters.length > 0) {
114-
const entry = this._serializeFilters(
115-
listener.dimId,
116-
listener.dimLabel,
117-
filters
114+
return this._serializeFilters(
115+
listener.dimId,
116+
listener.dimLabel,
117+
filters
118118
);
119-
if (includeStorageKey) {
120-
entry.storageKey = listener.storageKey;
121-
}
122-
return entry;
123119
}
124120
}
125121
return undefined;

src/core/i-filter-storage.ts

+1-5
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,13 @@ export interface IFilterListenerParams {
99
applyFilters: (filters) => void;
1010
}
1111

12-
export interface ISerializeOpts {
13-
includeStorageKey?: boolean;
14-
}
15-
1612
export interface IFilterStorage {
1713
setFiltersFor(storageKey: any, filters);
1814
getFiltersFor(storageKey: any);
1915
registerFilterListener(opts: IFilterListenerParams): any;
2016
deRegisterFilterListener(storageKey: any, listner: any): void;
2117
notifyListeners(storageKey: any, filters): void;
2218
deRegisterAll(): void;
23-
serialize(opts?: ISerializeOpts): ISerializedFilters[];
19+
serialize(): ISerializedFilters[];
2420
restore(state: object): void;
2521
}

0 commit comments

Comments
 (0)