Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Allow instances of generic data tests to be documented dbt-core #2578 #6293

Open
FishtownBuildBot opened this issue Oct 15, 2024 · 0 comments · May be fixed by #6307
Open

[Core] Allow instances of generic data tests to be documented dbt-core #2578 #6293

FishtownBuildBot opened this issue Oct 15, 2024 · 0 comments · May be fixed by #6307
Assignees
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.9 improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@FishtownBuildBot
Copy link

FishtownBuildBot commented Oct 15, 2024

At a minimum, update body to include a link to the page on docs.getdbt.com requiring updates and what part(s) of the page you would like to see updated.
Originating from this issue: dbt-labs/dbt-core#2578

Key changes include the addition of a description attribute to generic tests, updates to the parser to handle this new attribute, and new functional and unit tests to verify the implementation.

Enhancements to Generic Data Tests:

  • Added a description attribute to generic tests in core/dbt/parser/generic_test_builders.py to allow users to provide descriptions for tests, and ensured it is not passed into the test macro or name synthesis.
  • Updated the create_test_node and parse_generic_test functions in core/dbt/parser/schema_generic_tests.py to include the description attribute in the test node metadata.
@runleonarun runleonarun added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.9 labels Oct 15, 2024
@runleonarun runleonarun changed the title [Core] Docs Changes Needed from dbt-core Issue #2578 [Core] Allow instances of generic data tests to be documented dbt-coreore #2578 Oct 15, 2024
@runleonarun runleonarun changed the title [Core] Allow instances of generic data tests to be documented dbt-coreore #2578 [Core] Allow instances of generic data tests to be documented dbt-core #2578 Oct 15, 2024
@matthewshaver matthewshaver self-assigned this Oct 15, 2024
@matthewshaver matthewshaver linked a pull request Oct 17, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.9 improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants