Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech debt] Add Postgres container for development so that integration tests can be run via Docker #99

Open
3 tasks done
mikealfare opened this issue May 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mikealfare
Copy link
Contributor

mikealfare commented May 20, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-postgres functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Running integration tests against Postgres requires a manual setup of Postgres locally. It would be nice if this were automated, especially for community contributors that may not have Postgres always running locally. Additionally, this would support developing in a Docker container via docker/dev.Dockerfile since the connection credentials and parameters would all be deterministic.

Describe alternatives you've considered

We could do nothing. This would leave in the current state:

  • developers must manually setup Postgres for integration tests
  • development via the provided Docker container would not be able to run integration tests

Who will this benefit?

Any contributors to dbt-postgres, including maintainers.

Are you interested in contributing this feature?

No response

Anything else?

No response

@mikealfare mikealfare added enhancement New feature or request triage labels May 20, 2024
@jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 removed the triage label May 21, 2024
@mikealfare
Copy link
Contributor Author

@mikealfare Do you see this as being the same or different from what we have in dbt-core today?

* https://github.com/dbt-labs/dbt-core/blob/main/docker-compose.yml

* https://github.com/dbt-labs/dbt-core/blob/341803d78454f26932267b4c5da361c83556e96a/Makefile#L101-L105

Ah, I didn't realize we already had that. Yes, it would probably be very similar. I would just set that up in the dbt-postgres repo and then make sure we could use it with the local virtual environment as well as a dev Docker environment.

@mikealfare mikealfare changed the title [Tech debt] Add Postgres container for developmehnt so that integration tests can be run via Docker [Tech debt] Add Postgres container for development so that integration tests can be run via Docker Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants