Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using "compare_with_owner" or "compare_with_trigger" with KEY_BOARD_POSITION sets the board position to the relevant card #168

Open
BertezBertez opened this issue Nov 26, 2021 · 9 comments
Labels
enhancement New feature or request scripting engine Modifications on things that affect the way scripting works

Comments

@BertezBertez
Copy link

BertezBertez commented Nov 26, 2021

Good If you want to drag a card to a spot and have a card spawn there for example

@db0
Copy link
Owner

db0 commented Nov 27, 2021

If the spawned card is directly on top of the owner, then it will hide it as well though.

@BertezBertez
Copy link
Author

Hmm, maybe there could also be a spawn_offset key in spawn card that takes a vector2 which it adds for board position. Could be useful for other values that are conditional such as ones based off the viewport and such.

@BertezBertez
Copy link
Author

Alternatively a change board position task might be nice. That could follow the spawn card task and not put extra functionality on the spawn card task

@db0
Copy link
Owner

db0 commented Nov 28, 2021

Why don't you just use a 'move_card_to_board' on the spawned card?

@BertezBertez
Copy link
Author

oh can you use compare_with_owner for the position in move_card_to_board?

@db0
Copy link
Owner

db0 commented Nov 29, 2021

Well, no. I was replying to this comment

Alternatively a change board position task might be nice.

@db0 db0 added enhancement New feature or request scripting engine Modifications on things that affect the way scripting works labels Nov 29, 2021
@BertezBertez
Copy link
Author

I guess what I was thinking was a task to move a card based on where it is. Like add 50 to the X position.

@db0
Copy link
Owner

db0 commented Nov 29, 2021

If your name needs it, it is not difficult to extend the scripting engine and add this sort of task. If you feel it needs to be in the core CGF, feel free to send me a PR

@BertezBertez
Copy link
Author

That makes sense. I stuff is busy right now but I would like to give back to the project

@BertezBertez BertezBertez changed the title using "compate_with_owner" or "compare_with_trigger" with KEY_BOARD_POSITION sets the board position to the relevant card using "compare_with_owner" or "compare_with_trigger" with KEY_BOARD_POSITION sets the board position to the relevant card Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scripting engine Modifications on things that affect the way scripting works
Projects
None yet
Development

No branches or pull requests

2 participants