Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust QUICKSTART to also add card_label_min_sizes and original_font_sizes for new label #145

Open
Sky84 opened this issue Jun 25, 2021 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@Sky84
Copy link

Sky84 commented Jun 25, 2021

Step to reproduce : Follow the QUICKSTART step.

At the end, when we add just in res://src/new_card_game/CreatureFront.gd : text_expansion_multiplier["Health"] = 3; that is not enough.
To me, it's working if I add this few lines after:
card_labels["Health"] = $Margin/CardText/HB/Health; original_font_sizes["Health"] = 10; card_label_min_sizes["Health"] = Vector2(40,13);

@db0
Copy link
Owner

db0 commented Jun 26, 2021

The guide is a bit old by now, so it's possible it need some update. However I don't see instructing to add the expansion_multiplier. Also the card_labels setup is done as part of the guide in the ready() function

func _ready() -> void:
	card_labels["Health"] = $Margin/CardText/HB/Health

@Sky84
Copy link
Author

Sky84 commented Jun 27, 2021

Oh yes, sorry. I was talking about the card_labels in reality ^^'

@db0
Copy link
Owner

db0 commented Jun 27, 2021

I do need to update the guide to mention the card_label_min_sizes and original_font_sizes dictionaries I added recently.

@db0 db0 changed the title Following QUICKSTART guide don't finish with a build working Adjust QUICKSTART to also add card_label_min_sizes and original_font_sizes for new label Jun 27, 2021
@db0 db0 added the documentation Improvements or additions to documentation label Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants