Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variant="inside" for DBDrawer #3262

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Sep 30, 2024

Proposed changes

closes #3258

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget enabled auto-merge (squash) September 30, 2024 13:21
@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Sep 30, 2024
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-drawer-non-modal

@mfranzke mfranzke added this to the v0.5.0 milestone Oct 10, 2024
@mfranzke mfranzke removed this from the v0.5.0 milestone Oct 27, 2024
@nmerget nmerget added this to the v0.6.0 milestone Nov 1, 2024
mfranzke
mfranzke previously approved these changes Nov 4, 2024
@nmerget nmerget merged commit dbed551 into main Nov 6, 2024
73 checks passed
@nmerget nmerget deleted the feat-drawer-non-modal branch November 6, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏘components Changes inside components folder 📺showcases Changes to 1-n showcases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow opening DBDrawer with show besides of backdrop prop
2 participants