Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tabs): a11y validity #2570

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

refactor(tabs): a11y validity #2570

wants to merge 6 commits into from

Conversation

mfranzke
Copy link
Member

Proposed changes

Resolves #2567

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added 🍄🆙improvement New feature or request 👂accessibility Accessibility issues/improvements labels Apr 23, 2024
@mfranzke mfranzke self-assigned this Apr 23, 2024
@mfranzke mfranzke linked an issue Apr 23, 2024 that may be closed by this pull request
Tabs: a11y validity #2567
Open
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/2567-tabs-a11y-validity

@github-actions github-actions bot added the 🏘components Changes inside components folder label Apr 23, 2024
@mfranzke mfranzke changed the title 2567 tabs a11y validity refactor(tabs): a11y validity Apr 23, 2024
@mfranzke mfranzke modified the milestones: Open Beta Release - Leftovers (0.2.0), Guidelines 3.0 RC Jun 19, 2024
@bruno-sch
Copy link
Collaborator

@mfranzke is this proposal intended as a final solution or rather interim until we rebuild the tabs?

@mfranzke mfranzke removed this from the Guidelines 3.0 RC milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget will be requested when the pull request is marked ready for review nmerget is a code owner

@annsch annsch Awaiting requested review from annsch annsch will be requested when the pull request is marked ready for review annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch will be requested when the pull request is marked ready for review bruno-sch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

Labels
👂accessibility Accessibility issues/improvements 🏘components Changes inside components folder 🍄🆙improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabs: a11y validity
2 participants
@mfranzke @bruno-sch