Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: button with invalid variant prop renders now correctly #2521

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix: button with invalid variant prop renders now correctly #2521

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfc5cc7
fix: button with invalid variant prop renders now correctly
bruno-sch Apr 15, 2024
5445aab
Merge branch 'main' into fix-button-invalid-variant-renders-incorrect
bruno-sch Apr 15, 2024
0d9d6d3
test: updated screenshots
mfranzke Apr 16, 2024
fb489ad
Merge branch 'main' into fix-button-invalid-variant-renders-incorrect
mfranzke Apr 16, 2024
690dd8d
Update packages/components/src/components/button/button.scss
bruno-sch Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...utton/component/chromium/DBButton-should-match-screenshot-for-variant-brand.png
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong ^.^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no way !

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../button/component/chromium/DBButton-should-only-have-icon-for-variant-brand.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...button/component/firefox/DBButton-should-match-screenshot-for-variant-brand.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ..._/button/component/firefox/DBButton-should-only-have-icon-for-variant-brand.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../component/mobile-chrome/DBButton-should-match-screenshot-for-variant-brand.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...on/component/mobile-chrome/DBButton-should-only-have-icon-for-variant-brand.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ..._/button/showcase/chromium/regular/neutral/DBButton-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...__/button/showcase/firefox/regular/neutral/DBButton-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ton/showcase/mobile-chrome/regular/neutral/DBButton-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ton/showcase/mobile-safari/regular/neutral/DBButton-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s__/button/showcase/webkit/regular/neutral/DBButton-should-match-screenshot.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion packages/components/src/components/button/button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@
}

&[data-variant="outlined"],
&:not([data-variant]),
&:not([data-variant="filled"]),
&:not([data-variant="brand"]),
bruno-sch marked this conversation as resolved.
Show resolved Hide resolved
&[data-variant="ghost"] {
background-color: colors.$db-current-color-bg-transparent-full-enabled;
}
Expand Down
Loading