Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBButton: empty prop variant="" creates unexpected combination of variants filled and outlined #2444

Open
1 of 7 tasks
mfranzke opened this issue Apr 8, 2024 · 4 comments · May be fixed by #2521
Open
1 of 7 tasks

DBButton: empty prop variant="" creates unexpected combination of variants filled and outlined #2444

mfranzke opened this issue Apr 8, 2024 · 4 comments · May be fixed by #2521
Assignees
@bruno-sch
Labels
🐛bug Something isn't working

Comments

@mfranzke
Copy link
Member

mfranzke commented Apr 8, 2024 •
edited
Loading

Which generators are impacted?

  • All
  • HTML
  • React
  • Angular
  • Vue
  • Web components
  • Power Apps

Reproduction case

empty prop variant="" creates unexpected combination of variants filled and outlined

Expected Behaviour

tbd

Screenshots

No response

Browser version

None

Add any other context about the problem here.

No response
@mfranzke mfranzke added the 🐛bug Something isn't working label Apr 8, 2024
@nmerget
Copy link
Member

nmerget commented Apr 12, 2024

@bruno-sch is it only in vue or can we reproduce it here?

@bruno-sch
Copy link
Collaborator

@nmerget yes, this bug can be reproduced in any framework or just by using html + css.

@nmerget
Copy link
Member

nmerget commented Apr 15, 2024

@nmerget yes, this bug can be reproduced in any framework or just by using html + css.

If I open https://db-ui.github.io/mono/review/main/components/button/overview and change it in the dom nothing happens

@bruno-sch
Copy link
Collaborator

bruno-sch commented Apr 15, 2024 •
edited
Loading

Sorry, my mistake: you have to use data-variant="" to see the bug. But anyway, I've already fixed the bug and linked the PR...

Bildschirmfoto 2024-04-15 um 17 14 07

@bruno-sch bruno-sch linked a pull request Apr 15, 2024 that will close this issue
Draft
5 tasks
@mfranzke mfranzke added this to the Open Beta Release milestone Apr 16, 2024
@mfranzke mfranzke modified the milestones: Open Beta Release (0.1.0), v0.5.0 Sep 26, 2024
@mfranzke mfranzke removed this from the v0.5.0 milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bruno-sch bruno-sch

Labels
🐛bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: button with invalid variant prop renders now correctly db-ui/mono
3 participants
@mfranzke @nmerget @bruno-sch