Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: using :user-*valid from now on #936

Merged
merged 2 commits into from
Aug 22, 2024
Merged

refactor: using :user-*valid from now on #936

merged 2 commits into from
Aug 22, 2024

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Aug 19, 2024 •
edited
Loading

Partly resolves #933

@mfranzke mfranzke added this to the Guidelines v2 milestone Aug 19, 2024
@mfranzke mfranzke self-assigned this Aug 19, 2024
@mfranzke mfranzke linked an issue Aug 19, 2024 that may be closed by this pull request
form fields: validation styling without validation rules #933
Open
@mfranzke mfranzke marked this pull request as draft August 19, 2024 10:58
@github-actions github-actions bot added documentation Improvements or additions to documentation patterns labels Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/933-form-fields-validation-styling-without-validation-rules

@mfranzke mfranzke changed the title refactor: using :user-*valid from now on form fields: validation styling without validation rules Aug 19, 2024
@mfranzke mfranzke changed the title form fields: validation styling without validation rules refactor: using :user-*valid from now on Aug 19, 2024
@mfranzke mfranzke removed their assignment Aug 19, 2024
@mfranzke mfranzke marked this pull request as ready for review August 19, 2024 10:59
@mfranzke mfranzke enabled auto-merge (squash) August 19, 2024 10:59
@nmerget nmerget self-requested a review August 22, 2024 07:49
@mfranzke mfranzke merged commit d9dc1c1 into main Aug 22, 2024
12 checks passed
@mfranzke mfranzke deleted the 933-form-fields-validation-styling-without-validation-rules branch August 22, 2024 07:53
@mfranzke mfranzke added the 🪩 🔥 🕺 cool topic some relevant topics, that we even also need to report in different rounds / to stakeholders label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees
No one assigned
Labels
🪩 🔥 🕺 cool topic some relevant topics, that we even also need to report in different rounds / to stakeholders documentation Improvements or additions to documentation improvement patterns
Projects
None yet
Milestone
Guidelines v2
Development

Successfully merging this pull request may close these issues.

form fields: validation styling without validation rules
2 participants
@mfranzke @nmerget