Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(sass): version migration #1011

Merged
merged 8 commits into from
Nov 18, 2024
Merged

refactor(sass): version migration #1011

merged 8 commits into from
Nov 18, 2024

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Nov 18, 2024 •
edited
Loading

There were some deprecated code constructs that we needed to get migrated to the new way of writing this code, like:

  • color functions
  • string functions
  • map-get becomes map.get

@mfranzke mfranzke self-assigned this Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/refactor-sass-version-migration

@mfranzke mfranzke removed their assignment Nov 18, 2024
@mfranzke mfranzke marked this pull request as ready for review November 18, 2024 07:57
@mfranzke mfranzke enabled auto-merge (squash) November 18, 2024 07:57
@mfranzke mfranzke merged commit bc5c4b9 into main Nov 18, 2024
19 checks passed
@mfranzke mfranzke deleted the refactor-sass-version-migration branch November 18, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees
No one assigned
Labels
improvement patterns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mfranzke