[Bug]: Non-daemon executor thread in Clojure prevents clean JVM shutdown

[oliyh]

What happened?

Hi,

Firstly thank you for the great library, it transformed the way I thought about building UIs and it's so much more elegant than redux and so much cleaner than React hooks.

I have a library called re-graph which uses re-frame mostly for state management of websocket lifecycle. It runs in both cljs and clj, and we have uncovered an issue with the clj implementation which is preventing clean shutdown of the JVM because of an executor thread which is left running.

The full conversation is here: oliyh/re-graph#75

@lowecg has produced some code which works around the issue, but I think this would be best incorporated into re-frame (or maybe re-frame-test) and I'd be grateful to know what you think.

Thanks for your time

Version

1.2.0

What runtimes are you seeing the problem on?

JVM (CLJC)

Relevant console output

No response

[kimo-k]

Hey, I'd be happy to look into this. However, day8 are in crunch mode, so we can't spare much time until next Spring.

Please make a PR with explanation & references to the java features. The more straightforward the writing, the sooner we can merge it.

[lowecg]

I've created a minimal project demonstrating the issue: https://github.com/lowecg/re-frame-issue-809

I'll issue a PR shortly

[lowecg]

@kimo-k / @oliyh Thanks for you time on this. PR raised - I hope it meets expectation :-) Let me know if you need anything else.