Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Diffing #272

Open
mike-thompson-day8 opened this issue Jul 13, 2020 · 1 comment
Open

Better Diffing #272

mike-thompson-day8 opened this issue Jul 13, 2020 · 1 comment

Comments

@mike-thompson-day8
Copy link
Contributor

mike-thompson-day8 commented Jul 13, 2020

In various places, the re-frame-10x user interface shows how data has changed between one epoch and the next.

It currently uses clojure.data/diff to calculate these diffs.

But perhaps we should be using Editscript instead?

Also, see this analysis: https://juji.io/blog/comparing-clojure-diff-libraries/

@superstructor superstructor self-assigned this Mar 29, 2021
@superstructor
Copy link
Contributor

deep-diff2 seems like the recommended way to go for

If you want to look at the diffs and do not care if the diffs are always the smallest possible, deep-diff2 is great.

It is also written in CLJC, so runs in ClojureScript.

However, the only way of "pretty printing" in the docs mentions Puget and Fipp, which are Clojure-only. So its not yet clear how one would colourise the output w/ ClojureScript.

@superstructor superstructor modified the milestone: v1.1.0 Mar 29, 2021
@superstructor superstructor removed their assignment Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants