Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :min-rows arg to simple-v-table #260

Open
Gregg8 opened this issue Mar 3, 2021 · 0 comments
Open

Add :min-rows arg to simple-v-table #260

Gregg8 opened this issue Mar 3, 2021 · 0 comments
Assignees

Comments

@Gregg8
Copy link
Contributor

Gregg8 commented Mar 3, 2021

As per the docs, by default, simple-v-table is vertically polite. In other words, it only takes up as much vertical space as it's parents and siblings allow.

We have a way to make it even less greedy via the :max-rows argument, so that when the model reaches a certain number of rows, it stop taking up any more height and relies on its own vertical scrollbar.

Because if this politeness, we sometimes get the situation where you only see the top header section with zero rows underneath, even though there are plenty to show. It looks like a bug.

So let's look at being greedy. Currently, we have two options:

  • Add a :min-height style (:height is not sufficient) to the :simple-wrapper part
  • We can also assign a fixed height to it's parent but this could be a problem if the fixed height siblings it has to contend with are already greedy, so that is fraught with danger

Therefore, it would be very useful to have a :min-rows partner arg to :max-rows. The default could be set to 1.

Ideally this would be an intelligent minimum, such that if you had it set to say five, but there were only two rows in the model, it would only take up the vertical space for two rows.

@Gregg8 Gregg8 self-assigned this Mar 3, 2021
@Gregg8 Gregg8 changed the title Add :min-rows to simple-v-table Add :min-rows arg to simple-v-table Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant