minor symfony#45902 Leverage non-capturing catches (fancyweb)

This PR was merged into the 6.1 branch.

Discussion
----------

Leverage non-capturing catches

| Q             | A
| ------------- | ---
| Branch?       | 6.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

9c3bdb7 Leverage non-capturing catches

Author: fabpot

src/Symfony/Bridge/Doctrine/Form/DoctrineOrmTypeGuesser.php

@@ -176,9 +176,9 @@ protected function getMetadata(string $class)
         foreach ($this->registry->getManagers() as $name => $em) {
             try {
                 return $this->cache[$class] = [$em->getClassMetadata($class), $name];
-            } catch (MappingException $e) {
+            } catch (MappingException) {
                 // not an entity or mapped super class
-            } catch (LegacyMappingException $e) {
+            } catch (LegacyMappingException) {
                 // not an entity or mapped super class, using Doctrine ORM 2.2
             }
         }

src/Symfony/Bridge/Doctrine/Messenger/DoctrinePingConnectionMiddleware.php

@@ -39,7 +39,7 @@ private function pingConnection(EntityManagerInterface $entityManager)
 
         try {
             $connection->executeQuery($connection->getDatabasePlatform()->getDummySelectSQL());
-        } catch (DBALException $e) {
+        } catch (DBALException) {
             $connection->close();
             $connection->connect();
         }

src/Symfony/Bridge/Doctrine/PropertyInfo/DoctrineExtractor.php

@@ -212,7 +212,7 @@ private function getMetadata(string $class): ?ClassMetadata
     {
         try {
             return $this->entityManager->getClassMetadata($class);
-        } catch (MappingException|OrmMappingException $exception) {
+        } catch (MappingException|OrmMappingException) {
             return null;
         }
     }

src/Symfony/Bridge/Doctrine/Security/RememberMe/DoctrineTokenProvider.php

@@ -163,7 +163,7 @@ public function verifyToken(PersistentTokenInterface $token, string $tokenValue)
         // we also accept it as a valid value.
         try {
             $tmpToken = $this->loadTokenBySeries($tmpSeries);
-        } catch (TokenNotFoundException $e) {
+        } catch (TokenNotFoundException) {
             return false;
         }
 

src/Symfony/Bridge/Doctrine/Types/AbstractUidType.php

@@ -80,7 +80,7 @@ public function convertToDatabaseValue($value, AbstractPlatform $platform): ?str
 
         try {
             return $this->getUidClass()::fromString($value)->$toString();
-        } catch (\InvalidArgumentException $e) {
+        } catch (\InvalidArgumentException) {
             throw ConversionException::conversionFailed($value, $this->getName());
         }
     }

src/Symfony/Bridge/Doctrine/Validator/DoctrineLoader.php

@@ -50,7 +50,7 @@ public function loadClassMetadata(ClassMetadata $metadata): bool
         $className = $metadata->getClassName();
         try {
             $doctrineMetadata = $this->entityManager->getClassMetadata($className);
-        } catch (MappingException|OrmMappingException $exception) {
+        } catch (MappingException|OrmMappingException) {
             return false;
         }
 

src/Symfony/Bridge/Twig/AppVariable.php

@@ -139,7 +139,7 @@ public function getFlashes(string|array $types = null): array
             if (null === $session = $this->getSession()) {
                 return [];
             }
-        } catch (\RuntimeException $e) {
+        } catch (\RuntimeException) {
             return [];
         }
 

src/Symfony/Bridge/Twig/DataCollector/TwigDataCollector.php

@@ -71,7 +71,7 @@ public function lateCollect()
             if ($profile->isTemplate()) {
                 try {
                     $template = $this->twig->load($name = $profile->getName());
-                } catch (LoaderError $e) {
+                } catch (LoaderError) {
                     $template = null;
                 }
 

src/Symfony/Bridge/Twig/Extension/SecurityExtension.php

@@ -46,7 +46,7 @@ public function isGranted(mixed $role, mixed $object = null, string $field = nul
 
         try {
             return $this->securityChecker->isGranted($role, $object);
-        } catch (AuthenticationCredentialsNotFoundException $e) {
+        } catch (AuthenticationCredentialsNotFoundException) {
             return false;
         }
     }

src/Symfony/Bridge/Twig/Mime/BodyRenderer.php

@@ -85,7 +85,7 @@ private function getFingerPrint(TemplatedEmail $message): string
         $payload = [$messageContext, $message->getTextTemplate(), $message->getHtmlTemplate()];
         try {
             $serialized = serialize($payload);
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             // Serialization of 'Closure' is not allowed
             // Happens when context contain a closure, in that case, we assume that context always change.
             $serialized = random_bytes(8);