Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid helpUri generated #66

Open
FlorianKleemiss opened this issue Feb 4, 2022 · 2 comments
Open

Invalid helpUri generated #66

FlorianKleemiss opened this issue Feb 4, 2022 · 2 comments

Comments

@FlorianKleemiss
Copy link

Integrating flawfinder in my github repo I revieved a .sarif report generated, that has the following entry:

{
  "$schema": "https://schemastore.azurewebsites.net/schemas/json/sarif-2.1.0-rtm.5.json",
  "version": "2.1.0",
  "runs": [
    {
      "tool": {
        "driver": {
          "name": "Flawfinder",
          "version": "2.0.19",
          "informationUri": "https://dwheeler.com/flawfinder/",
          "rules": [
            {
[...]
              "id": "FF1057",
              "name": "misc/InitializeCriticalSection",
              "shortDescription": {
                "text": "Exceptions can be thrown in low-memory situations."
              },
              "defaultConfiguration": {
                "level": "warning"
              },
              "helpUri": ")",
              "relationships": []
            },

Uploading the result .sarif file caused an error in the workflow:

{
    "property": "instance.runs[0].tool.driver.rules[3].helpUri",
    "message": "does not conform to the \"uri\" format",
    "schema": {
      "description": "A URI where the primary documentation for the report can be found.",
      "type": "string",
      "format": "uri"
    },
    "instance": ")",
    "name": "format",
    "argument": "uri",
    "stack": "instance.runs[0].tool.driver.rules[3].helpUri does not conform to the \"uri\" format"
  }
Error: Unable to upload "/home/runner/work/wfn2fchk/wfn2fchk/flawfinder_results.sarif" as it is not valid SARIF:
- instance.runs[0].tool.driver.rules[3].helpUri does not conform to the "uri" format

Thank you for looking into this!

@cooljeanius
Copy link

Possible dups of this: #67 and #78

@dkt01
Copy link

dkt01 commented Jul 25, 2024

This is fixed in 56ffb9f, but the latest 2.0.19 release still has the bug. #78 is a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants