New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve backup/restore classes #1

Open

nvarscar opened this issue Feb 20, 2023 · 0 comments

Labels

core enhancement

Collaborator

nvarscar commented Feb 20, 2023

Currently, backup/restore classes use arrays of strings to define the corresponding OS commands.

        self.on_start_commands = [f'gsutil cp "{{path}}" "{self.temp_path}/{{filename}}"']
        self.on_finish_commands = [f'rm -f "{self.temp_path}/{{filename}}"']
        self.command = f'{{binary}} {{options}} -d "{{database}}" "{self.temp_path}/{{filename}}"'

This should be improved to use pre/exec/post methods and an abstract class should be created that requires those methods to be implemented.

nvarscar added enhancement core labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment