Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOH - broken link to function source #18

Open
petervandivier opened this issue Jul 9, 2024 · 1 comment
Open

BOH - broken link to function source #18

petervandivier opened this issue Jul 9, 2024 · 1 comment

Comments

@petervandivier
Copy link

Consider https://dataplat.github.io/boh#Remove-DbaDatabaseSafely

BOH page showing outgoing link in tooltip

Note that currently the link to the source code is of the format ...blob/development/functions/...

The /functions/ folder structure was changed in dataplat/dbatools#8737 - the BOH links need updating to the new format.

AFAICT, the necessary change should go here:

return '<a target="_blank" href="https://github.com/dataplat/dbatools/blob/' + activebranch + '/functions/' + data + '.ps1">' + data + '</a>'

- return '<a target="_blank" href="https://github.com/dataplat/dbatools/blob/' + activebranch + '/functions/' + data + '.ps1">' + data + '</a>'
+ return '<a target="_blank" href="https://github.com/dataplat/dbatools/blob/' + activebranch + '/public/' + data + '.ps1">' + data + '</a>'
@petervandivier
Copy link
Author

FWIW - IDK if private functions have BOH pages so a complete fix may require choice logic, but I reckon that the quick-fix is a marginal improvement in the meantime (assuming the line I flagged is the correct place for the fix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant