imp(phonenumber): now generates valid Swedish phone numbers

Author: bodiam

NOTES.md

@@ -0,0 +1,22 @@
+# Notes
+
+## Merging from Javafaker 
+
+```
+git remote add javafaker https://github.com/DiUS/java-faker.git\n
+git fetch javafaker pull/693/head:pr693
+git merge pr693
+```
+
+## Publish docs
+
+```
+mkdocs gh-deploy
+```
+
+## Publish to maven central
+
+```
+mvn deploy
+```
+

docs/releases/1.1.0-snapshot.md

@@ -13,8 +13,9 @@ contributions to Datafaker.
 ## Notable changes
 
 * Breaking (minor) change: `Relationships` has been renamed to `Relationship`.
-* Bufix: Fixed Russian translation ([PR #693](https://github.com/DiUS/java-faker/issues/693) by Sergey Nuyanzin)
+* Bugfix: Fixed Russian translation ([PR #693](https://github.com/DiUS/java-faker/issues/693) by Sergey Nuyanzin)
 * Improvement: Added mountain ranges ([PR #696](https://github.com/DiUS/java-faker/pull/696) by Sergey Nuyanzin)
 * Improvement: Minimised external dependencies. Removed Guava and Apache Commons from production dependencies, and logging from test dependencies.
 * Improvement: New `examplify` method in Faker, which generates a value by example, with the same pattern as the input value. (See the Javadoc for examples). [PR #4](https://github.com/datafaker-net/datafaker/pull/4) by Amit Solankurkar.
 * Bugfix: Removed 226 area code as reported here [Issue #698](https://github.com/DiUS/java-faker/issues/698).
+* Improvement: Now supports valid Swedish (sv_SE) phone numbers

src/main/resources/sv.yml

@@ -60,7 +60,11 @@ sv:
         - "#{prefix} #{first_name} #{last_name}"
 
     phone_number:
-      formats: ['####-#####', '####-######']
+      area_code_3: ["011", "013", "016", "018", "019", "020", "021", "023", "026", "031", "033", "035", "036", "040", "042", "044", "046", "054", "060", "063"]
+      area_code_4: ["0120", "0121", "0122", "0123", "0125", "0140", "0141", "0142", "0143", "0144", "0150", "0151", "0152", "0155", "0156", "0157", "0158", "0159", "0171", "0173", "0174", "0175", "0176", "0220", "0221", "0222", "0223", "0224", "0225", "0226", "0227", "0240", "0241", "0243", "0246", "0247", "0248", "0250", "0251", "0253", "0258", "0270", "0271", "0278", "0280", "0281", "0290", "0291", "0292", "0293", "0294", "0295", "0297", "0300", "0301", "0302", "0303", "0304", "0320", "0321", "0322", "0325", "0340", "0345", "0346", "0370", "0371", "0372", "0380", "0381", "0382", "0383", "0390", "0392", "0393", "0410", "0411", "0413", "0414", "0415", "0416", "0417", "0418", "0430", "0431", "0433", "0435", "0451", "0454", "0455", "0456", "0457", "0459", "0470", "0471", "0472", "0474", "0476", "0477", "0478", "0479", "0480", "0481", "0485", "0486", "0490", "0491", "0492", "0493", "0494", "0495", "0496", "0498", "0499", "0500", "0501", "0502", "0503", "0504", "0505", "0506", "0510", "0511", "0512", "0513", "0514", "0515", "0520", "0521", "0522", "0523", "0524", "0525", "0526", "0528", "0530", "0531", "0532", "0533", "0534", "0550", "0551", "0552", "0553", "0554", "0555", "0560", "0563", "0564", "0565", "0570", "0571", "0573", "0580", "0581", "0582", "0583", "0584", "0585", "0586", "0587", "0589", "0590", "0591", "0611", "0612", "0613", "0620", "0621", "0622", "0623", "0624", "0640", "0642", "0643", "0644", "0645", "0647", "0650", "0651", "0652", "0653", "0657", "0660", "0661", "0662", "0663", "0670", "0671", "0672", "0680", "0682", "0684", "0687", "0690", "0691", "0692", "0693", "0695", "0696", "0771", "0910", "0911", "0912", "0913", "0914", "0915", "0916", "0918", "0920", "0921", "0922", "0923", "0924", "0925", "0926", "0927", "0928", "0929", "0930", "0932", "0933", "0934", "0935", "0940", "0941", "0942", "0943", "0950", "0951", "0952", "0953", "0954", "0960", "0961", "0970", "0971", "0973", "0975", "0976", "0977", "0978", "0980"]
+      formats:
+        - "#{PhoneNumber.area_code_3}-#######"
+        - "#{PhoneNumber.area_code_4}-######"
     cell_phone:
       formats:
         - '070-###-####'

src/test/java/net/datafaker/MoodTest.java

@@ -1,7 +1,6 @@
 package net.datafaker;
 
 import org.junit.Test;
-
 import static net.datafaker.matchers.MatchesRegularExpression.matchesRegularExpression;
 import static org.hamcrest.MatcherAssert.assertThat;
 

src/test/java/net/datafaker/PhoneNumberTest.java

@@ -31,6 +31,17 @@ public void testAllCellPhone_enUS() throws NumberParseException {
         assertTrue(util.isValidNumberForRegion(proto, "US"));
     }
 
+    final Faker sefaker = new Faker(new Locale("sv_SE"));
+
+    @Test
+    @Repeat(times = 1000)
+    public void testAllCellPhone_svSE() throws NumberParseException {
+        String phoneNumber = sefaker.phoneNumber().phoneNumber();
+        PhoneNumberUtil util = PhoneNumberUtil.getInstance();
+        Phonenumber.PhoneNumber proto = util.parse(phoneNumber, "SE");
+        assertTrue(phoneNumber, util.isValidNumberForRegion(proto, "SE"));
+    }
+
     @Test
     public void testPhone_esMx() {
         final Faker f = new Faker(new Locale("es_MX"));