Merge pull request #15 from data-platform-hq/disable-public-ip-by-default

fix: disable public ip assignment by default

Author: owlleg6

README.md

@@ -64,7 +64,7 @@ module "ado_vmss_agent_pool" {
 | <a name="input_ado_service_connection_azurerm_name"></a> [ado\_service\_connection\_azurerm\_name](#input\_ado\_service\_connection\_azurerm\_name) | Name of existing Azure DevOps Service Connection AzureRM that points to Azure Subscription with VMSS used in agent pool | `string` | n/a | yes |
 | <a name="input_ado_vmss_pool_configuration"></a> [ado\_vmss\_pool\_configuration](#input\_ado\_vmss\_pool\_configuration) | Object with configuration options for Azure DevOps VMSS agent pool | <pre>object({<br>    desired_idle           = optional(number, 0)<br>    max_capacity           = optional(number, 3)<br>    time_to_live_minutes   = optional(number, 30)<br>    recycle_after_each_use = optional(bool, false)<br>  })</pre> | `{}` | no |
 | <a name="input_ado_vmss_pool_name"></a> [ado\_vmss\_pool\_name](#input\_ado\_vmss\_pool\_name) | Given name to Azure DevOps VMSS agent pool | `string` | n/a | yes |
-| <a name="input_ado_vmss_public_ip_prefix_enabled"></a> [ado\_vmss\_public\_ip\_prefix\_enabled](#input\_ado\_vmss\_public\_ip\_prefix\_enabled) | Boolean flag that determines whether Public IP Prefix is assigned to VM Scale Sets | `bool` | `true` | no |
+| <a name="input_ado_vmss_public_ip_prefix_enabled"></a> [ado\_vmss\_public\_ip\_prefix\_enabled](#input\_ado\_vmss\_public\_ip\_prefix\_enabled) | Boolean flag that determines whether Public IP Prefix is assigned to VM Scale Sets | `bool` | `false` | no |
 | <a name="input_analytics_workspace_id"></a> [analytics\_workspace\_id](#input\_analytics\_workspace\_id) | Resource ID of Log Analytics Workspace | `string` | `null` | no |
 | <a name="input_create_ado_resources"></a> [create\_ado\_resources](#input\_create\_ado\_resources) | Boolean flag that determines whether ADO resources will be created | `bool` | `true` | no |
 | <a name="input_drc_datasource_name"></a> [drc\_datasource\_name](#input\_drc\_datasource\_name) | Datasource syslog name | `string` | `"datasource-syslog"` | no |

variables.tf

@@ -47,7 +47,7 @@ variable "ado_vmss_pool_configuration" {
 variable "ado_vmss_public_ip_prefix_enabled" {
   description = "Boolean flag that determines whether Public IP Prefix is assigned to VM Scale Sets"
   type        = bool
-  default     = true
+  default     = false
 }
 
 variable "create_ado_resources" {