Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add retries to validation test to reduce flakiness #177

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

mmanciop
Copy link
Member

@mmanciop mmanciop commented Nov 6, 2023

No description provided.

@mmanciop mmanciop requested a review from bripkens November 6, 2023 17:15
Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
otelbin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 5:15pm

Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmanciop
Copy link
Member Author

mmanciop commented Nov 6, 2023

Shameless application of jest.retryTimes for the rescue. This looks better than raising the timeout for cold starts to something ridiculous like 15 seconds.

@mmanciop mmanciop self-assigned this Nov 6, 2023
@mmanciop mmanciop added bug Something isn't working priority-1 labels Nov 6, 2023
Copy link
Member

@bripkens bripkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bripkens bripkens disabled auto-merge November 7, 2023 06:15
@bripkens bripkens merged commit ab7966d into main Nov 7, 2023
27 checks passed
@bripkens bripkens deleted the retry-flaky branch November 7, 2023 06:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working priority-1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants