fix: OtelBin sonarCloud issues fix #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
fixed sonarCloud issues @bripkens |
bripkens
approved these changes
Nov 5, 2023
| @@ -82,22 +82,22 @@ export default function ErrorConsole({ errors, font }: { errors?: IError; font: | |||
| {errors?.ajvErrors && | |||
| errors.ajvErrors?.length > 0 && | |||
| errors.ajvErrors.map((error: IAjvError, index: number) => { | |||
| return <Error key={index} error={error} font={font} />; | |||
There was a problem hiding this comment.
Issue: The naming is a bit confusing, as this can also be a warning. Similar for the component CountErrorMessages
|
Kudos, SonarCloud Quality Gate passed!
|
roshan-gh
commented
Nov 5, 2023
There was a problem hiding this comment.
@bripkens better now?
|
@bripkens it seems sonarCloud generated a couple of new code smells. I will fix them too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.