Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-node copy operations #401

Closed
devreal opened this issue May 11, 2017 · 3 comments
Closed

Fix multi-node copy operations #401

devreal opened this issue May 11, 2017 · 3 comments

Comments

@devreal
Copy link
Member

devreal commented May 11, 2017

dash::copy is broken for copy operations spanning more than the current node and its neighbors.

Example:

dash::Array<int> arr(dash::size());
std::vector<int> vec(dash::size());

dash::copy(vec.begin(), vec.end(), arr.begin());

with dash::size() > 3.

Related: #386 for dash::transform

@fuchsto
Copy link
Member

fuchsto commented May 12, 2017

It's the local-to-global variants only, right? Global-to-local copying has been evaluated and benchmarked in lots of use cases, I would expect it's fine, Local-to-global has just been implemented for a single scenario and didn't get any love, yet.
And, yes, that's annoying ... as you wrote yesterday, it's crucial to document "restricted" implementations like this one

The n-dim ranges and views can solve the underlying partitioning problem. So I prioritize documentation of views first and then power-wash the algorithms section.

@devreal
Copy link
Member Author

devreal commented May 12, 2017

It's the local-to-global variants only, right? Global-to-local copying has been evaluated and benchmarked in lots of use cases, I would expect it's fine, Local-to-global has just been implemented for a single scenario and didn't get any love, yet.

Yes, you're right. I seem to have missed the while loop in the global-to-local overload of copy_impl that iterates over the source units.

The n-dim ranges and views can solve the underlying partitioning problem. So I prioritize documentation of views first and then power-wash the algorithms section.

Sounds good to me 👍

@devreal
Copy link
Member Author

devreal commented May 12, 2017

Closing this as a duplicate of #346

@devreal devreal closed this as completed May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants