diff --git a/app/lib/frontend/dom/dom.dart b/app/lib/frontend/dom/dom.dart index c180c94c2..07e3a1945 100644 --- a/app/lib/frontend/dom/dom.dart +++ b/app/lib/frontend/dom/dom.dart @@ -109,8 +109,11 @@ Node xAgoTimestamp(DateTime timestamp, {String? datePrefix}) { href: '', title: title, attributes: { - 'aria-label': text, - 'aria-role': 'button', + // Note: We change the `text` and the `title` when the user clicks this button. + // We do not use `aria-label`, so that the screenreader will read the + // appropriate change. + // We do not use `aria-pressed`, so that the screenreader will not read + // "toggle button pressed" as part of the text. 'role': 'button', 'data-timestamp': timestamp.millisecondsSinceEpoch.toString(), }, diff --git a/app/test/frontend/golden/my_activity_log_page.html b/app/test/frontend/golden/my_activity_log_page.html index 59947e962..b97e2cf28 100644 --- a/app/test/frontend/golden/my_activity_log_page.html +++ b/app/test/frontend/golden/my_activity_log_page.html @@ -146,7 +146,7 @@

admin

admin@pub.dev

Joined - %%x-ago%% + %%x-ago%%

@@ -185,7 +185,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -203,7 +203,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -221,7 +221,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -239,7 +239,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -255,7 +255,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -273,7 +273,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -291,7 +291,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -307,7 +307,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -325,7 +325,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -341,7 +341,7 @@

admin

- %%x-ago%% + %%x-ago%%
@@ -359,7 +359,7 @@

admin

- %%x-ago%% + %%x-ago%%
diff --git a/app/test/frontend/golden/my_liked_packages.html b/app/test/frontend/golden/my_liked_packages.html index d4d547d31..95c1fdecf 100644 --- a/app/test/frontend/golden/my_liked_packages.html +++ b/app/test/frontend/golden/my_liked_packages.html @@ -147,7 +147,7 @@

user

user@pub.dev

Joined - %%x-ago%% + %%x-ago%%

@@ -192,7 +192,7 @@

@@ -210,7 +210,7 @@

diff --git a/app/test/frontend/golden/my_packages.html b/app/test/frontend/golden/my_packages.html index 321ef6c19..3db3aa8ab 100644 --- a/app/test/frontend/golden/my_packages.html +++ b/app/test/frontend/golden/my_packages.html @@ -146,7 +146,7 @@

user

user@pub.dev

Joined - %%x-ago%% + %%x-ago%%

@@ -232,11 +232,11 @@

v 1.2.0 ( - %%x-ago%% + %%x-ago%% ) / 2.0.0-dev ( - %%x-ago%% + %%x-ago%% )

@@ -181,7 +181,7 @@

Registered - %%x-ago%% + %%x-ago%% .

diff --git a/app/test/frontend/golden/pkg_activity_log_page.html b/app/test/frontend/golden/pkg_activity_log_page.html index 7546028f6..511f02642 100644 --- a/app/test/frontend/golden/pkg_activity_log_page.html +++ b/app/test/frontend/golden/pkg_activity_log_page.html @@ -153,7 +153,7 @@

Published - %%x-ago%% + %%x-ago%% • Latest: @@ -256,7 +256,7 @@

Metadata

- %%x-ago%% + %%x-ago%%
@@ -266,7 +266,7 @@

Metadata

- %%x-ago%% + %%x-ago%%
@@ -284,7 +284,7 @@

Metadata

- %%x-ago%% + %%x-ago%%
@@ -302,7 +302,7 @@

Metadata

- %%x-ago%% + %%x-ago%%
@@ -322,7 +322,7 @@

Metadata

- %%x-ago%% + %%x-ago%%
@@ -340,7 +340,7 @@

Metadata

- %%x-ago%% + %%x-ago%%
diff --git a/app/test/frontend/golden/pkg_admin_page.html b/app/test/frontend/golden/pkg_admin_page.html index e4b0eecfc..41e10a46d 100644 --- a/app/test/frontend/golden/pkg_admin_page.html +++ b/app/test/frontend/golden/pkg_admin_page.html @@ -153,7 +153,7 @@