Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autosuggest missing #8

Open
darajava opened this issue Mar 27, 2016 · 4 comments
Open

autosuggest missing #8

darajava opened this issue Mar 27, 2016 · 4 comments

Comments

@darajava
Copy link
Owner

not sure if this one is possible to fix..

@angrybacon
Copy link

Was it impossible to keep the input and add your logic on it rather than crafting a new one? This would fix #27.

@darajava
Copy link
Owner Author

darajava commented Jun 3, 2016

No, that's not possible (well maybe it is) but when you submit their search input, it does some mad stuff as it's a single page app, and not simply requesting a form. No matter what I did, I couldn't intercept submission of that input.

@angrybacon
Copy link

angrybacon commented Jun 3, 2016

I don't really know jQuery that well. I was thinking about something like binding RET on the input that is already present. Depending on whether YouTube itself uses jQuery (and you use your own version, not too sure what kind of sorcery this may breed), you might need to empty the list of event for RET or preventDefault. This also requires you to handle click events on search candidates (and the markup looks quite troublesome/random to find with jQuery).

Or you could just build your own suggestion dropdown?

But this is just speculative, as I don't know neither of YouTube's APi nor your code.

@darajava
Copy link
Owner Author

I will create this myself in a future update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants